fix(timetable): check that a time cell isn't a frequency start/end time

landonreed · landonreed · commit fe31d609b188 · 2018-01-29T17:58:43.000-05:00
This fix avoids an NPE when attempting to fetch the pattern stop with an undefined stopTimeIdx.
Frequency entries in the timetable do not need stop time objects.
diff --git a/lib/editor/components/timetable/TimetableGrid.js b/lib/editor/components/timetable/TimetableGrid.js
@@ -287,15 +287,17 @@ export default class TimetableGrid extends Component {
       updateCellValue
     } = this.props
 
-    // determine if the value is a time entry
+    // Determine if the value is a time entry.
     if (isTimeFormat(col.type)) {
       // make sure stop time isn't null
       const splitColKeys = col.key.split('.')
       const stopTimeIdx = splitColKeys[1]
       const trip = data[rowIndex]
       const stopTime = trip.stopTimes[stopTimeIdx]
-      if (!stopTime) {
-        // stop time is null.  Create new stop time
+      if (!stopTime && col.key.indexOf('.') !== -1) {
+        // If stop time is null and there is a '.' in the column key, create a
+        // new stop time. If there is no '.', this is a frequency start/end
+        // time, which does not need a new stop time entry.
 
         // get stop id from pattern
         const {stopId} = activePattern.patternStops[stopTimeIdx]
