feat(FeedTransformation): Add normalize field transformation

binh-dam-ibigroup · binh-dam-ibigroup · commit c64125e27bb8 · 2021-03-19T18:16:36.000-04:00
diff --git a/i18n/english.yml b/i18n/english.yml
@@ -244,6 +244,9 @@ components:
     DeleteRecordsTransformation:
       label: Delete records from %tablePlaceholder%
       name: Delete records transformation
+    NormalizeFieldTransformation:
+      label: Normalize fields
+      name: Normalize fields transformation
     ReplaceFileFromStringTransformation:
       label: Replace %tablePlaceholder% from %filePlaceholder%
       name: Replace file from string transformation
diff --git a/lib/common/constants/index.js b/lib/common/constants/index.js
@@ -34,6 +34,7 @@ export const RETRIEVAL_METHODS = Object.freeze({
 
 export const FEED_TRANSFORMATION_TYPES = Object.freeze({
   DELETE_RECORDS: 'DeleteRecordsTransformation',
+  NORMALIZE_FIELDS: 'NormalizeFieldTransformation',
   REPLACE_FILE_FROM_VERSION: 'ReplaceFileFromVersionTransformation',
-  REPLACE_FILE_FROM_STRING: 'ReplaceFileFromStringTransformation'
+  REPLACE_FILE_FROM_STRING: 'ReplaceFileFromStringTransformation',
 })
diff --git a/lib/manager/components/transform/FeedTransformRules.js b/lib/manager/components/transform/FeedTransformRules.js
@@ -32,7 +32,8 @@ function newFeedTransformation (type: string = 'ReplaceFileFromVersionTransforma
 
 const feedTransformationTypes = [
   'ReplaceFileFromVersionTransformation',
-  'ReplaceFileFromStringTransformation'
+  'ReplaceFileFromStringTransformation',
+  'NormalizeFieldTransformation'
 ]
 
 type TransformRulesProps = {
diff --git a/lib/manager/components/transform/FeedTransformation.js b/lib/manager/components/transform/FeedTransformation.js
@@ -27,8 +27,8 @@ type Props = {
  * Component that renders fields for a single feed transformation
  * (e.g., ReplaceFileFromStringTransformation).
  */
-export default class FeedTransformation extends Component<Props, {csvData: ?string}> {
-  state = { csvData: null }
+export default class FeedTransformation extends Component<Props, {csvData: ?string, fieldName: ?string}> {
+  state = { csvData: null, fieldName: null }
 
   _getFieldsForType = (type: string) => {
     const {feedSource, transformation} = this.props
@@ -55,7 +55,7 @@ export default class FeedTransformation extends Component<Props, {csvData: ?stri
           />
         )
         break
-      case 'ReplaceFileFromStringTransformation':
+      case 'ReplaceFileFromStringTransformation': {
         const inputIsUnchanged = this.state.csvData === null
         const csvData = inputIsUnchanged
           ? transformation.csvData
@@ -96,6 +96,41 @@ export default class FeedTransformation extends Component<Props, {csvData: ?stri
           </div>
         )
         break
+      }
+      case 'NormalizeFieldTransformation': {
+        const inputIsUnchanged = this.state.fieldName === null
+        const fieldName = inputIsUnchanged
+          ? transformation.fieldName
+          : this.state.fieldName        
+        fields.push(
+          <div>
+            <label htmlFor='fieldName'>
+              Field to normalize:
+              <input
+                id='fieldName'
+                onChange={this._onChangeFieldToNormalize}
+                value={fieldName} />
+            </label>
+            <div style={{marginBottom: '10px'}}>
+              <Button
+                bsSize='xsmall'
+                disabled={inputIsUnchanged}
+                style={{marginRight: '5px'}}
+                onClick={this._onSaveFieldToNormalize}>
+                Save CSV
+              </Button>
+            </div>
+
+            This transform will:
+            <ul>            
+              <li>Capitalize bus stop names (for bus stops in all-caps),</li>
+              <li>Replace '+' and '&amp;' with 'and', '@' with 'at',</li>
+              <li>Remove contents within parentheses.</li>
+            </ul>
+          </div>
+        )
+        break
+      }
       default:
         break
     }
@@ -141,6 +176,16 @@ export default class FeedTransformation extends Component<Props, {csvData: ?stri
     this.props.onChange({csvData}, this.props.index)
   }
 
+  _onChangeFieldToNormalize = (evt: SyntheticInputEvent<HTMLInputElement>) => {
+    this.setState({fieldName: evt.target.value})
+  }
+
+  _onSaveFieldToNormalize = () => {
+    const fieldName = this.state.fieldName || null
+    this.setState({fieldName: null})
+    this.props.onChange({fieldName}, this.props.index)
+  }
+
   _onRemoveTransformation = () => {
     this.props.onRemove(this.props.index)
   }
diff --git a/lib/types/index.js b/lib/types/index.js
@@ -295,6 +295,7 @@ export type FeedTransformation = {
   '@type': $Values<typeof FEED_TRANSFORMATION_TYPES>,
   active: boolean,
   csvData?: string,
+  fieldName?: string,
   matchField?: string,
   matchValues?: Array<string>,
   sourceVersionId?: string,

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,8 @@ function newFeedTransformation (type: string = 'ReplaceFileFromVersionTransforma`
`32`	`32`
`33`	`33`	`const feedTransformationTypes = [`
`34`	`34`	`'ReplaceFileFromVersionTransformation',`
`35`		`- 'ReplaceFileFromStringTransformation'`
	`35`	`+ 'ReplaceFileFromStringTransformation',`
	`36`	`+ 'NormalizeFieldTransformation'`
`36`	`37`	`]`
`37`	`38`
`38`	`39`	`type TransformRulesProps = {`