fix: Fix issues from PR lint.

binh-dam-ibigroup · binh-dam-ibigroup · commit b7c0c50e1428 · 2020-01-28T15:42:43.000-05:00
diff --git a/lib/manager/components/version/FeedVersionViewer.js b/lib/manager/components/version/FeedVersionViewer.js
@@ -128,10 +128,10 @@ export default class FeedVersionViewer extends Component<Props> {
 }
 
 type SelectorProps = {
+  comparedVersion: FeedVersion,
   feedVersionIndex: number,
   gtfsPlusValidation: GtfsPlusValidation,
   version: FeedVersion,
-  comparedVersion: FeedVersion,
   versionSection: ?string
 }
 
@@ -150,26 +150,26 @@ class VersionSectionSelector extends Component<SelectorProps> {
     const text = hasCriticalError
       ? 'critical error'
       : validationSummary.errorCount
-    const diff = comparedVersion 
+    const diff = comparedVersion
       ? validationSummary.errorCount - comparedVersion.validationSummary.errorCount
       : 0
     const diffColor = diff > 0 ? 'danger' : (diff < 0 ? 'success' : 'default')
-    const diffText = comparedVersion 
+    const diffText = comparedVersion
       ? diff === 0 ? '=' : ((diff > 0 ? '+' : '') + numeral(diff).format('0a'))
       : ''
     return (
       <span>
-        <Label bsStyle={color}>
+        <Label bsStyle={color} htmlFor>
           {text}
         </Label>
-        {comparedVersion 
-          ? <Label bsStyle={diffColor} style={{paddingLeft: '0.2em', paddingRight: '0.2em'}}>
+        {comparedVersion
+          ? <Label bsStyle={diffColor} style={{paddingLeft: '0.2em', paddingRight: '0.2em'}} htmlFor>
             {diffText}
-            </Label>
+          </Label>
           : ''
         }
       </span>
-  )
+    )
   }
 
   _getGtfsPlusIssueCount = (gtfsPlusValidation: GtfsPlusValidation) => {
@@ -192,7 +192,7 @@ class VersionSectionSelector extends Component<SelectorProps> {
       : <Icon type='check' />
     return issueCount === null
       ? <span><Loading small inline /></span>
-      : <span><Label bsStyle={color}>{text}</Label></span>
+      : <span><Label bsStyle={color} htmlFor>{text}</Label></span>
   }
 
   render () {
@@ -227,7 +227,7 @@ class VersionSectionSelector extends Component<SelectorProps> {
             active={this.props.versionSection === 'comments'}>
             <ListGroupItem>
               <Glyphicon glyph='comment' /> Version comments{' '}
-              <Label>{version.noteCount}</Label>
+              <Label htmlFor>{version.noteCount}</Label>
             </ListGroupItem>
           </LinkContainer>
         </ListGroup>
