fix(patterns): fix pattern control point drag

landonreed · landonreed · commit 86229014d539 · 2018-01-29T14:12:00.000-05:00
During drag events, last control point distance was not updated properly and caused the line slice
along operation to fail because the end distance was less than the start distance.
diff --git a/lib/editor/util/map.js b/lib/editor/util/map.js
@@ -253,12 +253,17 @@ export async function recalculateShape ({
    * @param  {Number} endDistance
    * @return {Coordinate[]}
    */
-  function lineSliceAlongToCoords (startDistance, endDistance) {
+  function lineSliceAlongToCoords (startDistance, endDistance = null) {
     if (startDistance === 0 && endDistance === 0) {
       return []
     }
+    const lineSegment = lineString(patternShape.coordinates)
+    if (endDistance === null) {
+      // If no end distance provided, use distance of pattern shape
+      endDistance = lineDistance(lineSegment, 'kilometers')
+    }
     return lineSliceAlong(
-      lineString(patternShape.coordinates),
+      lineSegment,
       startDistance,
       endDistance
     ).geometry.coordinates
@@ -294,10 +299,7 @@ export async function recalculateShape ({
     if (index < controlPoints.length - 1) {
       // updating something before last stop
       points.push(followingControlPoint.point.geometry.coordinates)
-      followingCoords = lineSliceAlongToCoords(
-        mToKm(followingControlPoint.distance),
-        lastControlPointDistance
-      )
+      followingCoords = lineSliceAlongToCoords(mToKm(followingControlPoint.distance))
     }
   } else if (editType === 'delete') {
     if (index === 0) {
@@ -436,7 +438,7 @@ export async function recalculateShape ({
   } else {
     offset = segmentDistance - (followingControlPoint.distance - previousControlPoint.distance)
   }
-
+  // console.log(`offseting following control points by ${offset}`)
   controlPoints.slice(index + 1).forEach(controlPoint =>
     updatedControlPoints.push(cloneControlPointWithDistanceOffset(controlPoint, offset))
   )
