fix(deployment): fix type def for tripPlannerVersion

landonreed · landonreed · commit 122c6db4946c · 2021-05-06T11:37:07.000-04:00
diff --git a/lib/manager/components/deployment/DeploymentConfigurationsPanel.js b/lib/manager/components/deployment/DeploymentConfigurationsPanel.js
@@ -163,8 +163,6 @@ export default class DeploymentConfigurationsPanel extends Component<{
   render () {
     const { deployment, updateDeployment } = this.props
     const { customFileEditIdx, otp: options } = this.state
-    const isOtp = deployment.tripPlannerVersion.startsWith('OTP_')
-
     return (
       <Panel header={<h3><Icon type='cog' /> OTP Configuration</h3>}>
         <ListGroup fill>
@@ -182,17 +180,15 @@ export default class DeploymentConfigurationsPanel extends Component<{
               onChange={this._onUpdateTripPlannerVersion}
               options={TRIP_PLANNER_VERSIONS}
             />
-            {isOtp && (
-              <div>
-                OTP jar file
-                <Select
-                  clearable={false}
-                  value={deployment.otpVersion}
-                  onChange={this._onUpdateVersion}
-                  options={options ? options.map(v => ({value: v, label: v})) : []}
-                />
-              </div>
-            )}
+            <div>
+              OTP jar file
+              <Select
+                clearable={false}
+                value={deployment.otpVersion}
+                onChange={this._onUpdateVersion}
+                options={options ? options.map(v => ({value: v, label: v})) : []}
+              />
+            </div>
           </ListGroupItem>
           <ListGroupItem>
             Deploying to the{' '}
diff --git a/lib/types/index.js b/lib/types/index.js
@@ -247,7 +247,7 @@ export type Deployment = {
   projectId: string,
   routerId: ?string,
   skipOsmExtract: boolean,
-  tripPlannerVersion: 'OTP_1' | 'OTP_2',
+  tripPlannerVersion?: 'OTP_1' | 'OTP_2',
   user: ?any // TODO add more specific type
 }
 

Original file line number	Diff line number	Diff line change
`@@ -247,7 +247,7 @@ export type Deployment = {`
`247`	`247`	`projectId: string,`
`248`	`248`	`routerId: ?string,`
`249`	`249`	`skipOsmExtract: boolean,`
`250`		`- tripPlannerVersion: 'OTP_1' \| 'OTP_2',`
	`250`	`+ tripPlannerVersion?: 'OTP_1' \| 'OTP_2',`
`251`	`251`	`user: ?any // TODO add more specific type`
`252`	`252`	`}`
`253`	`253`