fix?: avoid annoying warning for "Surface 0x... is not initialized, skipping drawing"#6438
Open
thiswillbeyourgithub wants to merge 3 commits into
Open
fix?: avoid annoying warning for "Surface 0x... is not initialized, skipping drawing"#6438thiswillbeyourgithub wants to merge 3 commits into
thiswillbeyourgithub wants to merge 3 commits into
Conversation
Author
|
Report after 3 weeks: still no issue whatsoever. |
|
Confirmed. This fixed the problem (or in worst case the anoying log message) |
|
Works as expected, no crowded log anymore... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This is a possible fix to #5456.
It was made purely by aider-chat as I cannot read a single line of C.
I consider it bad practice in general to do this, but to the best of my prompting skills (which are lightyears away from my C skills), the LLMs acted sure of themselves and the fix was minimal. Additionally, I tested the fix and so far I can't reproduce the issue and have not noticed any regression.
I can provide the full chat logs of the LLMs if you're interested. The workflow I used is already detailed here. Both patch were done using gemini 2.5 and aider.
Can't wait to see what you have to say about this :/!
Edit: although I can't do C, I am still a dev, and can't help but notice that the fix sounds like it's just hiding the error. In the sense that obviously it just checks if the surface is not initialized before deciding to draw on it, so I'm willing to think there's a deep issue at play. But for my case: I have 230k useless lines of logs a month, and don't notice any regression so I don't plan on going back.