Move agent config and its dependencies into agent classloader - #322
Conversation
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
pavolloffay
changed the title
|
@ryandens it seems that snyk still fails on the PRs from forks. |
|
The CI passes not. Snyk is misconfigured and fails on PRs from forks on
|
|
The body capture works, tested on https://github.com/grpc/grpc-java/tree/master/examples
|
|
do not merge yet it needs more love - e.g. remove the filter paths from the instrumentation config. That should not be available to instrumentations. |
Signed-off-by: Pavol Loffay <p.loffay@gmail.com>
|
@shashank11p PR updated, could you please re-review? |
Hey Pavol! Sorry about that would you mind trying out a fix to help this PR along? I think we need to
|
|
I am not sure if that will work, most likely the secret is not present in PRs from forks https://github.com/pavolloffay/javaagent/blob/52f0a2d388ce5951e4627f6f18c0fa0f9e4f12a1/.github/workflows/build.yaml#L82. This repository has the same snyk setting as other HT repos e.g. https://github.com/hypertrace/hypertrace-service/blob/main/.github/workflows/pr-build.yml#L79. I will leave this as it is, somebody from the team should fix it so that PRs from the community are not turning red. EDIT: snyk passed on hypertrace/hypertrace-service#97. I will look at it in a different PR |
3 participants
Signed-off-by: Pavol Loffay p.loffay@gmail.com
Description
Resolves #313
Notable changes:
javaagent-corethat lives in the bootstrap classloader. The binding between the interface and proto-based config is done at javaagent bootstrap via component installer SPI.The whole idea is that
javaagent-coreis located in the bootstrap classloader hence it should not bring any other 3rd party dependencies. The otel-extensionsis located in the agent classloader and can load and use anything bc it is fully isolated from the application.