feat(async-queue): introduce PendingDispatch for fluent job dispatching#7623
Open
huangdijia wants to merge 2 commits intohyperf:3.2from
Open
feat(async-queue): introduce PendingDispatch for fluent job dispatching#7623huangdijia wants to merge 2 commits intohyperf:3.2from
huangdijia wants to merge 2 commits intohyperf:3.2from
Conversation
This commit introduces a new PendingDispatch class that provides a fluent interface for dispatching async queue jobs with enhanced flexibility and composability.
Key changes:
- Added PendingDispatch class with fluent methods: setMaxAttempts(), onPool(), delay()
- Integrated Conditionable trait for conditional method chaining (when/unless)
- Refactored dispatch() function to return PendingDispatch instead of bool
- Added hyperf/conditionable dependency to composer.json
- Job dispatch now happens automatically in PendingDispatch destructor
- Comprehensive test suite with 100% coverage of all features
Breaking change: dispatch() now returns PendingDispatch instead of bool. Users should not assign the return value unless they understand the implications (as noted in the function documentation).
Migration examples:
- Old: dispatch($job, 60, 3, 'custom');
- New: dispatch($job)->delay(60)->setMaxAttempts(3)->onPool('custom');
…or fluent job dispatching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a new PendingDispatch class that provides a fluent interface for dispatching async queue jobs with enhanced flexibility and composability.
Key changes:
Breaking change: dispatch() now returns PendingDispatch instead of bool. Users should not assign the return value unless they understand the implications (as noted in the function documentation).
Migration examples: