WebSocket Server allow dependencies.php overrides like Http Server#7454
Open
kingIZZZY wants to merge 2 commits intohyperf:masterfrom
Open
WebSocket Server allow dependencies.php overrides like Http Server#7454kingIZZZY wants to merge 2 commits intohyperf:masterfrom
kingIZZZY wants to merge 2 commits intohyperf:masterfrom
Conversation
Member
Code Review Summary✅ APPROVE - This is a solid improvement that increases consistency between WebSocket and HTTP servers. Key Points:
The change successfully allows dependencies.php to override CoreMiddleware, matching HTTP server behavior. Ready to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of hard-coded instantiating
new CoreMiddlewareDo the same as
Hyperf\HttpServer\ServerUse container
make()so it can use overrides of custom CoreMiddleware from config/autoload/dependencies.php