Skip to content

Fix: Use 0644 for files and 0755 for dirs in StorageManager #7788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix: Use 0644 for files and 0755 for dirs in StorageManager #7788

wants to merge 2 commits into from

Conversation

@sir1ke
Copy link

@sir1ke sir1ke commented Oct 17, 2025 •
edited
Loading

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the develop branch, not the master branch if no hotfix
  • When resolving a specific issue, it's referenced in the PR's description (e.g. Fix #xxx[,#xxx], where "xxx" is the Github issue number)
  • All tests are passing
  • New/updated tests are included
  • Changelog was modified

Other information:
Proposed solution to #7698
-> Maybe some solution is needed for existing files during upgrade?

@what-the-diff
Copy link

what-the-diff bot commented Oct 17, 2025

PR Summary

  • Updated the CHANGELOG.md
    This update documents a new fix that has been made in the 'StorageManager' which regards file and directory permissions. In simpler terms, this change improves how the software can manage permissions of files and folders.

  • Modified Default FileMode
    The normal setting for file permissions ('fileMode') has been adjusted from '0744' to '0644' in StorageManager.php. This makes the files more secure.

  • Introduced New Property DirMode
    A new property 'dirMode', with a default value of '0755', has been added to 'StorageManager.php'. It helps in managing permissions while creating a folder.

  • Updated Methods For Directory Creation
    The 'set', 'setContent', and 'setByPath' methods used to create new directories have been updated. They now use the 'dirMode' property.

  • Optimized "getPath" Method
    The 'getPath' method now utilizes the 'dirMode' instead of the 'fileMode' when creating new directories, providing better control over directory permissions.

  • Refactoring Function Syntax
    The syntax of the functions within 'getVariants' were refactored from arrow functions to standard function syntax. In simpler terms, this is a code cleaning process to make the function easier to read and maintain in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sir1ke