Allow to explicitly inflate WebRequestConcern responses using deflate#2801
Open
dsander wants to merge 1 commit into
Open
Allow to explicitly inflate WebRequestConcern responses using deflate#2801dsander wants to merge 1 commit into
WebRequestConcern responses using deflate#2801dsander wants to merge 1 commit into
Conversation
knu
approved these changes
May 27, 2020
| when 'gzip'.freeze | ||
| body.replace(ActiveSupport::Gzip.decompress(body)) | ||
| when 'deflate'.freeze | ||
| body.replace(Zlib::Inflate.inflate(body)) |
Member
There was a problem hiding this comment.
I have an experience that some Microsoft servers (not sure about the product and version) violating RFC used to return a raw deflate stream, and contributed a patch to faraday_middleware as shown below. You may need the same technique here.
Collaborator
Author
There was a problem hiding this comment.
Nice, thanks for the hint. I think ill change our code to use the middleware in both cases.
Some website do not send the correct header values, the new option value allows the user to explicitly inflate the response using deflate.
dsander
force-pushed
the
add-deflate-unzip-option
branch
from
67d522e to
0de04bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some website do not send the correct header values, the new option value
allows the user to explicitly inflate the response using deflate.