Remove padding_value from CPO and use pad_token_id#4962
Open
albertvillanova wants to merge 1 commit intohuggingface:mainfrom
Open
Remove padding_value from CPO and use pad_token_id#4962albertvillanova wants to merge 1 commit intohuggingface:mainfrom
albertvillanova wants to merge 1 commit intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
qgallouedec
reviewed
Feb 4, 2026
| self.max_length = max_length | ||
| self.generate_during_eval = args.generate_during_eval | ||
| self.padding_value = args.padding_value if args.padding_value is not None else processing_class.pad_token_id | ||
| self.pad_token_id = processing_class.pad_token_id |
Member
There was a problem hiding this comment.
the issue is that, if the tokenizer doesn't have a padding token (which we should allow), it will fail. We should align with stable trainers:
trl/trl/trainer/grpo_trainer.py
Lines 305 to 309 in 963d046
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove padding_value from CPO and use pad_token_id.
This PR removes the
padding_valueparameter from theCPOConfigclass and updates the trainer logic to always use the tokenizer'spad_token_idfor padding. This simplifies configuration and ensures consistent padding behavior throughout the codebase.Follow-up to: