fix: improve video processing fps and do_sample_frames assignment logic #42009
+42
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
1. Improve
fpshandling inQwen2_5_VLProcessor.__call__()Previously, the
__call__()function always defaulted tofps=2, regardless of the input video.Now, when fps is not explicitly provided and cannot be read from the video metadata, it falls back to 24 by default. Otherwise, the provided or metadata fps is used. It follows a priority order:
The default value 24 is chosen as it represents a common frame rate for most videos.
This prevents potential errors in
second_per_grid_tscalculation when the actual video frame rate differs from the assumed default.2. More robust
do_sample_framesbehaviorfpsis manually provided butdo_sample_framesis not specified,do_sample_frameswill now be automatically set to True.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@zucchini-nlp