Correct type hint in config models #41980
Open
+22
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ms norm config Signed-off-by: jorisSchaller <71265553+jorisSchaller@users.noreply.github.com>
|
[For maintainers] Suggested jobs to run (before merge) run-slow: deepseek_v2, deepseek_v3, dots1, gemma, gemma2, gemma3, granite, granitemoe, granitemoehybrid, granitemoeshared, jetmoe, llama, mistral, qwen2, qwen2_5_omni, qwen2_moe |
|
Looks good but please run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Most models are using a config with
rms_norm_eps: Optional[int] = 1e-6: I modified it to an optional float.This update configs that use a type of optional int instead of optional float for the epsilon value for their RMS norm.
You can clearly see that the epsilon has a default value of 10e-6 (float), the hint should therefore be adjusted.
FIx no issue.
Before submitting
Who can review?
Let me know if you want any changes, @ArthurZucker @Cyrilvallez @stevhliu, I tried to find all occurence of it, but some might have slipped through.