Skip to content

[gaudi] Remove unnecessary reinitialize to HeterogeneousNextTokenChooser to m…#3284

Merged
regisss merged 6 commits intohuggingface:mainfrom
sywangyi:do_sample_fix
Jul 3, 2025
Merged

[gaudi] Remove unnecessary reinitialize to HeterogeneousNextTokenChooser to m…#3284
regisss merged 6 commits intohuggingface:mainfrom
sywangyi:do_sample_fix

Conversation

@sywangyi
Copy link
Contributor

@sywangyi sywangyi commented Jul 2, 2025

…ake sampling output correct

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

…ake sampling output correct

Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@sywangyi
Copy link
Contributor Author

sywangyi commented Jul 2, 2025

@regisss please help merge it, gaudi specific issue when do_sample is true

sywangyi added 3 commits July 1, 2025 23:28
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@sywangyi
Copy link
Contributor Author

sywangyi commented Jul 2, 2025

@yuanwu2017 pls review

Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
Copy link
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@regisss regisss changed the title remove unnecessary reinitialize to HeterogeneousNextTokenChooser to m… [gaudi] Remove unnecessary reinitialize to HeterogeneousNextTokenChooser to m… Jul 3, 2025
@regisss regisss merged commit 778b61c into huggingface:main Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants