Skip to content

fix the crash in default ATTENTION path#3235

Merged
regisss merged 1 commit intohuggingface:mainfrom
sywangyi:default_crash
May 20, 2025
Merged

fix the crash in default ATTENTION path#3235
regisss merged 1 commit intohuggingface:mainfrom
sywangyi:default_crash

Conversation

@sywangyi
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@sywangyi
Copy link
Contributor Author

@regisss please help review. the api add kv_cache_dtype, so need to add in default ATTENTION path.

Copy link
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@regisss regisss merged commit 43b1b07 into huggingface:main May 20, 2025
@sywangyi sywangyi deleted the default_crash branch May 28, 2025 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants