Open
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR was closed because it has been stalled for 5 days with no activity. |
michaelbenayoun
commented
Feb 4, 2026
Comment on lines
+59
to
+63
| if not self.experimental: | ||
| raise ValueError( | ||
| "NeuronGRPOTrainer is experimental and not production-ready. To proceed, set `experimental=True` in " | ||
| "your NeuronGRPOConfig. This flag exists to ensure users are aware of the current state of the implementation." | ||
| ) |
Member
Author
There was a problem hiding this comment.
For now we disable the access to the NeuronGRPOTrainer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds partial support for GRPO.
It was broken down into smaller PRs:
optimum/neuron/accelerate#1042It adds the
NeuronGRPOTrainerwith a set of optimizations and modifications for the Torch XLA backend used to run things on Trainium instances. There are still core missing features:NeuronGRPOTrainer <-> vLLM