fix(deps): bump diffusers cap to <0.39.0 (GHSA-98h9-4798-4q5v)#3612
Open
cagataycali wants to merge 1 commit into
Open
fix(deps): bump diffusers cap to <0.39.0 (GHSA-98h9-4798-4q5v)#3612cagataycali wants to merge 1 commit into
cagataycali wants to merge 1 commit into
Conversation
Diffusers 0.35.x is affected by GHSA-98h9-4798-4q5v (HIGH, CVSS 8.8): 'trust_remote_code bypass via custom_pipeline and local custom components'. Fixed in diffusers 0.38.0. Current cap 'diffusers<0.36.0' blocks downstream consumers (e.g. strands-labs/robots) from picking up the security fix. The lerobot diffusers surface area is narrow and stable across 0.36-0.38: - diffusers.schedulers.scheduling_ddim.DDIMScheduler - diffusers.schedulers.scheduling_ddpm.DDPMScheduler - diffusers.optimization.get_scheduler - diffusers.ConfigMixin / ModelMixin / register_to_config - diffusers.models.attention.{Attention,FeedForward} - diffusers.models.embeddings.* None of these were removed, renamed, or had breaking changes in 0.36, 0.37, or 0.38 release notes. Bumping the cap to <0.39.0 unblocks the security fix while keeping a major-version safety bound.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump the upper cap of the
diffusers-depextra from<0.36.0to<0.39.0.Why
diffusers<0.38.0is affected by GHSA-98h9-4798-4q5v (HIGH, CVSS 8.8) — atrust_remote_codebypass viacustom_pipelineand local custom components. The fix landed indiffusers==0.38.0.The current cap (
<0.36.0) means any project that depends onlerobot[diffusion]orlerobot[groot]is forced onto a vulnerable diffusers, with no path to the patched version. Downstream Dependabot alerts (e.g. https://github.com/strands-labs/robots/security/dependabot, alert #15) cannot be closed until this cap moves.Compatibility analysis
lerobotonly consumes a small, stable surface of thediffusersAPI. Auditing usages onmain:I reviewed the release notes for 0.36.0, 0.37.0, and 0.38.0 — none of these symbols were removed, renamed, signature-changed, or moved. The breaking-change items in those releases concern Stable Cascade, Qwen Image RoPE caching, Kandinsky 5, Chroma, Flax schedulers, torchao quantization config, etc. — none of them touch the schedulers / mixins / embeddings / optimization helpers that lerobot uses.
Risk
Low. The cap is widened by 3 minor versions of an internal-mixin / scheduler surface that lerobot uses in a stable way. Major-version safety is preserved (
<0.39.0).Validation
pyproject.toml.Downstream
Closes the path for downstream consumers like
strands-labs/robots(strands-labs/robots#153) to fully resolve their Dependabot alerts.