Skip to content

fix(unitree_g1): correct SDK detection and update installation docs#3115

Merged
imstevenpmwork merged 19 commits into
mainfrom
feat/unitree_g1_review
Mar 9, 2026
Merged

fix(unitree_g1): correct SDK detection and update installation docs#3115
imstevenpmwork merged 19 commits into
mainfrom
feat/unitree_g1_review

Conversation

@nepyope
Copy link
Copy Markdown
Collaborator

@nepyope nepyope commented Mar 9, 2026

Type / Scope

  • Type: Docs | Bug
  • Scope: robots/unitree_g1, pyproject.toml, docs

Summary / Motivation

The Unitree G1 integration had a broken package detection check and incomplete/incorrect installation docs. The SDK availability check looked for "unitree-sdk2" (the PyPI name) instead of "unitree-sdk2py" (the editable source install name), causing ImportError at runtime. The docs also had missing dependencies, incorrect install ordering (WiFi after install), and no guidance for the G1's broken pip on the Jetson Orin.

What changed

  • src/lerobot/utils/import_utils.py: Ensure SDK is correctly detected when installed from source.
  • pyproject.toml: Added onnx>=1.16.0,<2.0.0 to unitree_g1 extra. Removed pin, casadi, and EnvHub deps (mujoco, loguru, msgpack, msgpack-numpy, scipy) — pinocchio must come from conda-forge, and sim env deps belong to the EnvHub, not lerobot.
  • docs/source/unitree_g1.mdx: Refactor

Copilot AI review requested due to automatic review settings March 9, 2026 10:02
@github-actions github-actions Bot added the documentation Improvements or fixes to the project’s docs label Mar 9, 2026
@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the Unitree G1 setup by adjusting the unitree_g1 optional dependency set and expanding the documentation steps to build/configure CycloneDDS as part of the Unitree SDK installation flow.

Changes:

  • Remove the pinned unitree-sdk2==1.0.1 from the unitree_g1 extra and add several new runtime dependencies (including MuJoCo).
  • Expand docs/source/unitree_g1.mdx installation instructions to clone/build CycloneDDS and set CYCLONEDDS_HOME before installing unitree_sdk2_python.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.

File Description
pyproject.toml Adjusts the unitree_g1 optional dependency set (removes unitree-sdk2, adds MuJoCo/logging/serialization deps).
docs/source/unitree_g1.mdx Updates Unitree G1 installation instructions to include CycloneDDS build/install steps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread docs/source/unitree_g1.mdx Outdated
Comment thread docs/source/unitree_g1.mdx Outdated
Comment thread docs/source/unitree_g1.mdx Outdated
Comment thread docs/source/unitree_g1.mdx Outdated
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
nepyope and others added 4 commits March 9, 2026 11:24
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Martino Russi <77496684+nepyope@users.noreply.github.com>
@imstevenpmwork imstevenpmwork marked this pull request as draft March 9, 2026 10:41
nepyope and others added 6 commits March 9, 2026 11:42
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Martino Russi <77496684+nepyope@users.noreply.github.com>
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml
Comment thread pyproject.toml Outdated
Comment thread docs/source/unitree_g1.mdx Outdated
Comment thread docs/source/unitree_g1.mdx Outdated
Comment thread docs/source/unitree_g1.mdx
@nepyope nepyope marked this pull request as ready for review March 9, 2026 14:46
@imstevenpmwork imstevenpmwork self-assigned this Mar 9, 2026
@imstevenpmwork imstevenpmwork changed the title Feat/unitree g1 review fix(unitree_g1): correct SDK detection and update installation docs Mar 9, 2026
@imstevenpmwork imstevenpmwork merged commit 885ef91 into main Mar 9, 2026
13 checks passed
@imstevenpmwork imstevenpmwork deleted the feat/unitree_g1_review branch March 9, 2026 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or fixes to the project’s docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants