Skip to content

fix(policies): support dp train when n_obs_steps=1#2430

Merged
imstevenpmwork merged 5 commits into
huggingface:mainfrom
Hukongtao:fix_diffusion_train
Feb 25, 2026
Merged

fix(policies): support dp train when n_obs_steps=1#2430
imstevenpmwork merged 5 commits into
huggingface:mainfrom
Hukongtao:fix_diffusion_train

Conversation

@Hukongtao
Copy link
Copy Markdown
Contributor

What this does

#2277 (comment)

How it was tested

python -m lerobot.scripts.lerobot_train \
    --output_dir=outputs/train/dp_test_nobssteps1_1104 \
    --policy.type=diffusion \
    --policy.push_to_hub=false \
    --policy.crop_shape=[96,96] \
    --policy.noise_scheduler_type="DDPM" \
    --policy.n_obs_steps=1 \
    --policy.horizon=32 \
    --policy.n_action_steps=30 \
    --policy.drop_n_last_frames=2 \
    --dataset.repo_id=lerobot/pusht \
    --seed=100000 \
    --batch_size=64 \
    --steps=20000 \
    --log_freq=200 \
    --save_freq=5000 \
    --wandb.enable=false

How to checkout & try? (for the reviewer)

SECTION TO REMOVE BEFORE SUBMITTING YOUR PR

Note: Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR. Try to avoid tagging more than 3 people.

Note: Before submitting this PR, please read the contributor guideline.

Comment thread src/lerobot/policies/diffusion/modeling_diffusion.py
@Hukongtao
Copy link
Copy Markdown
Contributor Author

@Ke-Wang1017 Will this MR be considered to merge?

@Ke-Wang1017
Copy link
Copy Markdown
Contributor

@Ke-Wang1017 Will this MR be considered to merge?

@michel-aractingi will this be merged? I tested and it works

@Hukongtao
Copy link
Copy Markdown
Contributor Author

@michel-aractingi Hello, could you please take a look at this PR?

@Hukongtao
Copy link
Copy Markdown
Contributor Author

Can someone review this PR? @michel-aractingi @alexander-soare @aliberts @Cadene @AdilZouitine

@imstevenpmwork imstevenpmwork self-assigned this Feb 25, 2026
@imstevenpmwork imstevenpmwork self-requested a review February 25, 2026 14:56
@github-actions github-actions Bot added the policies Items related to robot policies label Feb 25, 2026
Copy link
Copy Markdown
Collaborator

@imstevenpmwork imstevenpmwork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@imstevenpmwork imstevenpmwork merged commit d0b5819 into huggingface:main Feb 25, 2026
8 checks passed
pkooij pushed a commit that referenced this pull request Feb 27, 2026
Co-authored-by: hukongtao <hukongtao@agibot.com>
Co-authored-by: Steven Palma <imstevenpmwork@ieee.org>
xianglunkai pushed a commit to xianglunkai/lerobot that referenced this pull request Feb 28, 2026
Co-authored-by: hukongtao <hukongtao@agibot.com>
Co-authored-by: Steven Palma <imstevenpmwork@ieee.org>
sorelferris pushed a commit to sorelferris/lerobot that referenced this pull request Mar 1, 2026
Co-authored-by: hukongtao <hukongtao@agibot.com>
Co-authored-by: Steven Palma <imstevenpmwork@ieee.org>
LePao1 pushed a commit to LePao1/lerobot that referenced this pull request Mar 7, 2026
Co-authored-by: hukongtao <hukongtao@agibot.com>
Co-authored-by: Steven Palma <imstevenpmwork@ieee.org>
lu391see pushed a commit to lu391see/lerobot_tactile that referenced this pull request Mar 24, 2026
Co-authored-by: hukongtao <hukongtao@agibot.com>
Co-authored-by: Steven Palma <imstevenpmwork@ieee.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

policies Items related to robot policies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants