Move IP Adapter Scripts to research project by ParagEkbote · Pull Request #9960 · huggingface/diffusers

ParagEkbote · 2024-11-19T07:32:08Z

What does this PR do?

I have moved the IP Adapter Scripts to the research project folder as mentioned, to close #7196. Please let me know if any further corrections are needed and I will make the necessary changes.

Similar to #9935 .

Before submitting

This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
Did you read the contributor guideline?
Did you read our philosophy doc (important for complex PRs)?
Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
Did you make sure to update the documentation with your changes? Here are the
documentation guidelines, and
here are tips on formatting docstrings.

Who can review?

@sayakpaul

sayakpaul · 2024-11-19T08:20:52Z

Can you cherry-pick the commits from #7196 and then add a commit to move them to research folder? This way, the original contributions receive the proper credits they deserve.

pcuenca · 2024-11-19T08:26:37Z

Can you cherry-pick the commits from #7196 and then add a commit to move them to research folder?

Agreed, or start the branch from the other PR's branch if that's easier.

ParagEkbote · 2024-11-19T08:34:11Z

I have copied the contents from #7196 and added them to research project. Should I credit the user in the ReadME, since the branch in that repository is out-of-date.

cc: @sayakpaul

sayakpaul · 2024-11-19T08:35:10Z

You should still be able to cherry-pick commits.

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>

to research_projects.

ParagEkbote · 2024-11-19T09:37:02Z

I have cherry-picked the commits and moved files to the research project folder. Please let me know if any further corrections are needed and I will make the necessary changes.

cc: @sayakpaul

sayakpaul · 2024-11-19T10:00:39Z

Can you run make style && make quality?

pcuenca · 2024-11-19T10:04:32Z

docs/source/en/_toctree.yml

    title: Working with big models
  title: Tutorials
 - sections:
+<<<<<<< HEAD


These are git conflict markers that need to be resolved.

…into Move-files

ParagEkbote · 2024-11-19T12:18:10Z

I have run the styling checks and resolved the git conflict. Please let me know if any further corrections are needed and I will make the necessary changes.

cc: @pcuenca

docs/source/en/training/ip_adapter.md

sayakpaul · 2024-11-19T12:32:13Z

docs/source/en/_toctree.yml

-  - local: using-diffusers/loading
-    title: Load pipelines
-  - local: using-diffusers/custom_pipeline_overview
-    title: Load community pipelines and components
-  - local: using-diffusers/schedulers
-    title: Load schedulers and models
-  - local: using-diffusers/other-formats
-    title: Model files and layouts
-  - local: using-diffusers/loading_adapters
-    title: Load adapters
-  - local: using-diffusers/push_to_hub
-    title: Push files to the Hub
-  title: Load pipelines and adapters


We should not be changing this

I have updated toctree.yml to reset the changes.

…into Move-files

sayakpaul · 2024-11-19T12:56:07Z

docs/source/en/_toctree.yml

      title: Video Processor
    title: Internal classes
-  title: API
+  title: API


No change here.

Sorry for the oversight, fixed the nit.

HuggingFaceDocBuilderDev · 2024-11-19T13:03:32Z

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

sayakpaul · 2024-11-19T13:20:37Z

@ParagEkbote could I ask you to be a bit more respectful of the maintainers’s time for PRs?

You have requested for reviews multiple times now and have also mentioned multiple times. This, IMO, seems unnecessary.

ParagEkbote · 2024-11-19T13:22:46Z

@sayakpaul Sorry, I'll try to do better.

sayakpaul · 2024-11-19T14:27:30Z

docs/source/en/_toctree.yml

+      title: Internal classes
  title: API
+


Why this change?

I have referenced the toctree.yml file from the main branch. In previous commits, the CI tests kept failing, so I corrected it.

Please run git restore -s main /path/to/toctree.yaml and push the changes

I've run the command as mentioned but there are no new changes to push.

This should be restored to how it was previously. We can help fix the CI test if it fails

- local: api/video_processor title: Video Processor title: Internal classes

sayakpaul · 2024-11-19T14:38:37Z

@stevhliu do the docs-related changes look good to you?

stevhliu

I noticed there are also some unresolved comments in the last PR here and here. Do you think you could also resolve those comments?

stevhliu · 2024-11-19T17:18:54Z

docs/source/en/_toctree.yml

+      title: Internal classes
  title: API
+


This should be restored to how it was previously. We can help fix the CI test if it fails

- local: api/video_processor title: Video Processor title: Internal classes

model format to .safetensors

stevhliu

Thanks!

ParagEkbote · 2024-11-19T18:43:05Z

Could you please see that #7196 gets closed to declutter?

cc: @stevhliu

* Move files to research-projects. * docs: add IP Adapter training instructions * Delete venv * Update examples/ip_adapter/tutorial_train_sdxl.py Co-authored-by: Sayak Paul <spsayakpaul@gmail.com> * Cherry-picked commits and re-moved files to research_projects. * make style. * Update toctree and delete ip_adapter. * Nit Fix * Fix nit. * Fix nit. * Create training script for single GPU and set model format to .safetensors * Add sample inference script and restore _toctree * Restore toctree.yaml * fix spacing. * Update toctree.yaml --------- Co-authored-by: AMohamedAakhil <a.aakhilmohamed@gmail.com> Co-authored-by: BootesVoid <78485654+AMohamedAakhil@users.noreply.github.com> Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>

Move files to research-projects.

3996b29

AMohamedAakhil and others added 4 commits November 19, 2024 09:30

docs: add IP Adapter training instructions

14b3c1f

Delete venv

2b91a16

Update examples/ip_adapter/tutorial_train_sdxl.py

886fc59

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>

Cherry-picked commits and re-moved files

a8968d1

to research_projects.

Merge branch 'main' into Move-files

e84e1a9

pcuenca reviewed Nov 19, 2024

View reviewed changes

ParagEkbote added 3 commits November 19, 2024 12:09

make style.

85a7583

Merge branch 'Move-files' of https://github.com/ParagEkbote/diffusers …

39c3cea

…into Move-files

Merge branch 'main' into Move-files

13da9cf

ParagEkbote requested a review from pcuenca November 19, 2024 12:18

sayakpaul reviewed Nov 19, 2024

View reviewed changes

docs/source/en/training/ip_adapter.md Outdated Show resolved Hide resolved

sayakpaul reviewed Nov 19, 2024

View reviewed changes

ParagEkbote added 2 commits November 19, 2024 12:46

Update toctree and delete ip_adapter.

bfdf57b

Merge branch 'Move-files' of https://github.com/ParagEkbote/diffusers …

9486a5e

…into Move-files

ParagEkbote requested a review from sayakpaul November 19, 2024 12:51

sayakpaul reviewed Nov 19, 2024

View reviewed changes

ParagEkbote added 3 commits November 19, 2024 13:03

Nit Fix

6f2718e

Fix nit.

a2194eb

Fix nit.

4d22b0d

ParagEkbote requested a review from sayakpaul November 19, 2024 13:13

Merge branch 'main' into Move-files

3f0bdbb

sayakpaul reviewed Nov 19, 2024

View reviewed changes

stevhliu reviewed Nov 19, 2024

View reviewed changes

ParagEkbote added 5 commits November 19, 2024 17:41

Create training script for single GPU and set

9179302

model format to .safetensors

Add sample inference script and restore _toctree

8231773

Restore toctree.yaml

5d8e6d7

fix spacing.

237b17a

Update toctree.yaml

6f64798

ParagEkbote requested a review from stevhliu November 19, 2024 18:09

stevhliu approved these changes Nov 19, 2024

View reviewed changes

stevhliu merged commit cc7d88f into huggingface:main Nov 19, 2024

ParagEkbote deleted the Move-files branch November 19, 2024 18:57

sayakpaul mentioned this pull request Nov 28, 2024

Train IP Adapter #7194

Closed

Conversation

ParagEkbote commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Before submitting

Who can review?

Uh oh!

sayakpaul commented Nov 19, 2024

Uh oh!

pcuenca commented Nov 19, 2024

Uh oh!

ParagEkbote commented Nov 19, 2024

Uh oh!

sayakpaul commented Nov 19, 2024

Uh oh!

ParagEkbote commented Nov 19, 2024

Uh oh!

sayakpaul commented Nov 19, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ParagEkbote commented Nov 19, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ParagEkbote Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

HuggingFaceDocBuilderDev commented Nov 19, 2024

Uh oh!

sayakpaul commented Nov 19, 2024

Uh oh!

ParagEkbote commented Nov 19, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sayakpaul commented Nov 19, 2024

Uh oh!

stevhliu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stevhliu left a comment

Choose a reason for hiding this comment

Uh oh!

ParagEkbote commented Nov 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ParagEkbote commented Nov 19, 2024 •

edited

Loading

ParagEkbote Nov 19, 2024 •

edited

Loading