Fixed Nits in Docs and Example Script#9940
Merged
stevhliu merged 2 commits intohuggingface:mainfrom Nov 18, 2024
ParagEkbote:nit-in-docs
Merged
Fixed Nits in Docs and Example Script#9940stevhliu merged 2 commits intohuggingface:mainfrom ParagEkbote:nit-in-docs
stevhliu merged 2 commits intohuggingface:mainfrom
ParagEkbote:nit-in-docs
Conversation
a-r-r-o-w
approved these changes
Nov 16, 2024
Contributor
a-r-r-o-w
left a comment
a-r-r-o-w
left a comment
There was a problem hiding this comment.
Thank you, this looks like the correct thing to do since we can't change argument names without breaking backwards compatibility!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
Author
|
Could you please see that #9087 and the issue #9027 gets closed to declutter? cc: @a-r-r-o-w |
This was referenced Nov 18, 2024
Contributor
|
Thanks for the fix and notifying! Marked those as closed |
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
Fixed nits in docs and example script. Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes the PR #9087 and Issue #9027. I've only updated the docstrings to not break anything. Please let me know if any improvements are needed and I will make the necessary changes.
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
cc: @yiyixuxu