Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Contributor
|
this seems really important but considering how slowly things move around here, not so sure it will be merged in a timely manner. |
yiyixuxu
approved these changes
Nov 17, 2024
Collaborator
yiyixuxu
left a comment
yiyixuxu
left a comment
There was a problem hiding this comment.
oh thanks for the fix!
I made a comment
| width = int(width) // self.vae_scale_factor | ||
| # VAE applies 8x compression on images but we must also account for packing which requires | ||
| # latent height and width to be divisible by 2. | ||
| height = int(height) // self.vae_scale_factor - ((int(height) // self.vae_scale_factor) % 2) |
Collaborator
There was a problem hiding this comment.
is this same as this? (basically revert back to the original code but divisible by self.vae_scale_factor*2
a little bit easier to understand, no?
height = 2 * (int(height) // (self.vae_scale_factor*2))
Collaborator
Author
|
Failing LoRA tests are unrelated. Merging. |
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
* update * update * update * update * update * update --------- Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR: #9711 changed the latent preparation step so that the
vae_scale_factorand default sample size are more clear.However, we overlooked the fact that this operation (with scale_factor == 16)
Is not equivalent to this operation with scale_factor == 8
For resolutions that are divisible by 8 but not by 16 the current pipeline on main will error out, because the implementation does not account for the fact that the latent width and height must be divisible by 2 for the packing step to work.
The old implementation scaled the height and width by
//16and then multiplied by 2. This results in slightly resized images if the height or width aren't multiples of 16.This PR:
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.