[refactor] enhance readability of flux related pipelines#9711
[refactor] enhance readability of flux related pipelines#9711yiyixuxu merged 4 commits intohuggingface:mainfrom
Conversation
Luciennnnnnn
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
@Luciennnnnnn can you run |
Sure! This is my first contribution to diffusers, i'll try it |
Done! |
|
The previous commit is failed on two checks, after modification, how to rerun checks |
|
Hi @yiyixuxu , I see checks failed on FLUX training examples, which is not related to my PR. How can I pass it? |
|
Hi @Luciennnnnnn thanks for the PR! It is a really nice PR Would you be interested in working on that? If not, I can take over when I have a little bit more time:) |
Sure! I have updated training example accordingly. |
yiyixuxu
left a comment
yiyixuxu
left a comment
There was a problem hiding this comment.
Thanks @Luciennnnnnn
really nice job:) hope to see more of your PRs soon
* flux pipline: readability enhancement.
4 participants
What does this PR do?
This PR refactors the FLUX-related pipelines to improve clarity and consistency, particularly in regards to height and width determination. The changes align the implementation more closely with other pipelines in the library, enhancing overall code coherence and maintainability.
The original code obscured the details of how latents packing affects resolution, but this change makes the process more transparent and easier to understand.
@yiyixuxu @asomoza