[CI] add a big GPU marker to run memory-intensive tests separately on CI#9691
[CI] add a big GPU marker to run memory-intensive tests separately on CI#9691
Conversation
.github/workflows/nightly_tests.yml
Outdated
|
|
||
| on: | ||
| workflow_dispatch: | ||
| pull_request: |
.github/workflows/nightly_tests.yml
Outdated
|
|
||
| jobs: | ||
| setup_torch_cuda_pipeline_matrix: | ||
| if: github.event_name == 'schedule' |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Ah okay then. No issues. |
|
@DN6 okay if I modified the failing tests to account for the machine change? |
|
|
||
| @slow | ||
| @require_torch_gpu | ||
| class FluxControlNetImg2ImgPipelineSlowTests(unittest.TestCase): |
There was a problem hiding this comment.
I don't think this test was correctly done as it doesn't pass the controlnet module to the pipeline and it also uses very dummy inputs which I think should be avoided for an integration test. LMK if you think otherwise.
|
@DN6 regarding https://github.com/huggingface/diffusers/actions/runs/11398910357/job/31716739483?pr=9691#step:7:67, my hunch is that there's some kind of leakage happening which is causing the worker to crash. When I SSH'd into the runner and manually ran the test, it passed. |
|
In a follow-up I will introduce the quantization tests. |
… CI (#9691) * add a marker for big gpu tests * update * trigger on PRs temporarily. * onnx * fix * total memory * fixes * reduce memory threshold. * bigger gpu * empty * g6e * Apply suggestions from code review * address comments. * fix * fix * fix * fix * fix * okay * further reduce. * updates * remove * updates * updates * updates * updates * fixes * fixes * updates. * fix * workflow fixes. --------- Co-authored-by: Aryan <aryan@huggingface.co>
… CI (#9691) * add a marker for big gpu tests * update * trigger on PRs temporarily. * onnx * fix * total memory * fixes * reduce memory threshold. * bigger gpu * empty * g6e * Apply suggestions from code review * address comments. * fix * fix * fix * fix * fix * okay * further reduce. * updates * remove * updates * updates * updates * updates * fixes * fixes * updates. * fix * workflow fixes. --------- Co-authored-by: Aryan <aryan@huggingface.co>
4 participants
What does this PR do?
I have only touched a handful of tests with the marker being introduced. I think we may need to change the slices based on the CI machine and infra. @a-r-r-o-w should consider marking the Cog tests similarly as well?
@DN6 would love to get your thoughts on the design.