Skip to content

add reshape to fix use_memory_efficient_attention in flax#7918

Merged
pcuenca merged 5 commits intohuggingface:mainfrom
entrpn:fix_flax_use_memory_efficient_attention
Dec 14, 2024
Merged

add reshape to fix use_memory_efficient_attention in flax#7918
pcuenca merged 5 commits intohuggingface:mainfrom
entrpn:fix_flax_use_memory_efficient_attention

Conversation

@entrpn
Copy link
Contributor

@entrpn entrpn commented May 11, 2024

What does this PR do?

Fixes #7895

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@pcuenca

@yiyixuxu yiyixuxu requested a review from pcuenca May 13, 2024 21:19
@sayakpaul
Copy link
Member

sayakpaul commented Jun 1, 2024

@pcuenca a gentle ping here.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 1, 2024

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Sep 14, 2024
@a-r-r-o-w a-r-r-o-w removed the stale Issues that haven't received updates label Nov 20, 2024
@a-r-r-o-w
Copy link
Contributor

a-r-r-o-w commented Nov 20, 2024

Gentle ping @pcuenca

@github-actions
Copy link
Contributor

github-actions bot commented Dec 14, 2024

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

@github-actions github-actions bot added the stale Issues that haven't received updates label Dec 14, 2024
pcuenca
pcuenca approved these changes Dec 14, 2024
View reviewed changes
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! Sorry for the super late review!

@pcuenca
Copy link
Member

pcuenca commented Dec 14, 2024

Failing tests are unrelated, merging.

@pcuenca pcuenca merged commit a5f35ee into huggingface:main Dec 14, 2024
13 of 15 checks passed
@entrpn
Copy link
Contributor Author

entrpn commented Dec 16, 2024

Thank you @pcuenca!

sayakpaul added a commit that referenced this pull request Dec 23, 2024
@entrpn @jfacevedo-google
@sayakpaul @a-r-r-o-w
add reshape to fix use_memory_efficient_attention in flax (#7918)
96f700c 
Co-authored-by: Juan Acevedo <jfacevedo@google.com>
Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Co-authored-by: Aryan <aryan@huggingface.co>
@entrpn entrpn deleted the fix_flax_use_memory_efficient_attention branch January 6, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pcuenca pcuenca pcuenca approved these changes

Assignees

No one assigned

Labels

stale Issues that haven't received updates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Flax's use_memory_efficient_attention is broken

6 participants

@entrpn @sayakpaul @HuggingFaceDocBuilderDev @a-r-r-o-w @pcuenca @jfacevedo-google