Conversation
|
Thanks for your contributions! Can we please break this PR into multiple PRs as it targets multiple mutually exclusive areas? |
|
@sayakpaul Yes, feel free to change it. |
|
Sorry for not being clear. I was asking you to tackle this in multiple PRs |
|
@sayakpaul I'm not familiar with git and it seems a little troublesome. Are there any doubtful changes? I can restore that part. |
|
It's a general good practice to not introduce multiple changes in a single PR. And I would like to follow that. For example, for each of the points you enlisted in the PR description, you could create PRs (four PRs). |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
|
@aihao2000 a gentle ping here |
aihao2000
force-pushed
the
update-train-scripts
branch
from
3432404 to
77697d4
Compare
|
@sayakpaul IIt is now only about the addition of the data_dir parameter. Is this okay? |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
| if args.dataset_name is None and args.train_data_dir is None: | ||
| raise ValueError("Need either a dataset name or a training folder.") |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
|
@aihao2000 can we address the last comment and get this merged? |
|
@yiyixuxu Should I submit a new commit to restore this code? |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
|
@aihao2000 yes |
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
|
can you run |
yiyixuxu
added
close-to-merge
and removed
stale
|
thanks @hlky ! |
* add data_dir parameter to load_dataset --------- Co-authored-by: Sayak Paul <spsayakpaul@gmail.com> Co-authored-by: YiYi Xu <yixu310@gmail.com> Co-authored-by: hlky <hlky@hlky.ac>
6 participants
What does this PR do?
Supports custom local datasets. Just like add load_datasete data_dir parameter #5747 (comment)
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@sayakpaul and @patrickvonplaten