Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
yiyixuxu
approved these changes
Feb 7, 2024
Collaborator
yiyixuxu
left a comment
yiyixuxu
left a comment
There was a problem hiding this comment.
why it is so flaky? this test use torch.float16 should we change it to 32
Collaborator
Author
|
Ah yes. That's probably it. Didn't see the dtype in the mixin. Yes let's run in 32 bit |
Collaborator
Author
|
Okay. I've split the tests up further by checkpoint so it's easier to pin point failures should they occur again. The SD 1.5 tests run in fp32, SDXL ones will have to run in fp16 because we'll hit OOM errors on the runner otherwise. Everything's passing locally. So hopefully this does the trick. |
JaLnYn
pushed a commit
to JaLnYn/diffusers
that referenced
this pull request
Feb 13, 2024
AmericanPresidentJimmyCarter
pushed a commit
to AmericanPresidentJimmyCarter/diffusers
that referenced
this pull request
Apr 26, 2024
dg845
pushed a commit
to dg845/diffusers
that referenced
this pull request
Dec 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Spoke too soon about IPAdapter tests. This should hopefully finally fix all of them. If we see further issues, we should consider adding the
flakydecorator.Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.