Skip to content

[Kandinsky tests] add is_flaky to test_model_cpu_offload_forward_pass #6762

Merged
sayakpaul merged 3 commits intomainfrom
add-flaky-decorator-kandinsky
Jan 31, 2024
Merged

[Kandinsky tests] add is_flaky to test_model_cpu_offload_forward_pass #6762
sayakpaul merged 3 commits intomainfrom
add-flaky-decorator-kandinsky

Conversation

@sayakpaul
Copy link
Member

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul
Copy link
Member Author

Failing test is unrelated. See; https://huggingface.slack.com/archives/C04L3MWLE6B/p1706601893641009

@sayakpaul
Copy link
Member Author

Nope is_flaky didn't solve it either :/

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still want this knowing that it did not fix the test? this slows down the tests, no?

@sayakpaul
Copy link
Member Author

We don't but it's not getting either. Maybe we should skip the test?

@DN6
Copy link
Collaborator

DN6 commented Jan 31, 2024

I think just bump up the precision to 8e-4

@sayakpaul
Copy link
Member Author

Let's get this merged.

@sayakpaul sayakpaul merged commit 0fc62d1 into main Jan 31, 2024
@sayakpaul sayakpaul deleted the add-flaky-decorator-kandinsky branch January 31, 2024 09:21
dg845 pushed a commit to dg845/diffusers that referenced this pull request Feb 2, 2024
…ss (huggingface#6762)

* add is_flaky to test_model_cpu_offload_forward_pass

* style

* update

---------

Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
AmericanPresidentJimmyCarter pushed a commit to AmericanPresidentJimmyCarter/diffusers that referenced this pull request Apr 26, 2024
…ss (huggingface#6762)

* add is_flaky to test_model_cpu_offload_forward_pass

* style

* update

---------

Co-authored-by: Dhruv Nair <dhruv.nair@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants