Repository navigation
Fix shared LoRA component weight broadcasting - #15128
Open
gorkadabo1 wants to merge 1 commit into
Open
gorkadabo1 wants to merge 1 commit into
gorkadabo1 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #15127. Approved by @sayakpaul.
When
set_adapters()receives a single component-weight dictionary for multiple LoRA adapters, only the first adapter gets the requested weight. The others use the default weight of1.0without warning. This PR replacespop()withget(), so the same dictionary can be used for the remaining adapters.It also adds regression tests for broadcast and shared-reference dictionaries, zero weights, reversed adapter order, and nested UNet block weights. The tests also check that inference outputs match.
Validation
Python 3.12.1, PyTorch 2.14.1 (CPU), PEFT 0.21.2.
make style: passed.make fix-copies: passed.make quality: passed.git diff --check: passed.Tests used CPU float32 and small test models. I did not run GPU, mixed-precision, quantized, or full-library tests.
AI assistance and self-review
I used Codex to help with the implementation, testing, and code review. The final self-review report, including findings, validation results, and limitations, is included below.
Final codex self-review report
Before submitting
Who can review?
@BenjaminBossan, as requested by @sayakpaul.