Open
Conversation
yiyixuxu
approved these changes
Feb 4, 2026
Collaborator
yiyixuxu
left a comment
yiyixuxu
left a comment
There was a problem hiding this comment.
really nice thanks!
should we start to add a guide for contributor some where, maybe https://huggingface.co/docs/diffusers/main/en/conceptual/contribution
dg845
reviewed
Feb 5, 2026
Collaborator
dg845
left a comment
dg845
left a comment
There was a problem hiding this comment.
Thanks! I see there are two Wan model related failures from the CI:
tests/models/transformers/test_models_transformer_wan_animate.py::TestWanAnimateTransformer3DAttention::test_fuse_unfuse_qkv_projectionstests/models/transformers/test_models_transformer_wan_vace.py::TestWanVACETransformer3DAttention::test_fuse_unfuse_qkv_projections
If I try to run the new Wan tests locally, for example with
pytest tests/models/transformers/test_models_transformer_wan.pyI get some more test failures:
tests/models/transformers/test_models_transformer_wan.py::TestWanTransformer3Dtest_keep_in_fp32_modulestest_from_save_pretrained_dtype_inference[fp16,bf16]
tests/models/transformers/test_models_transformer_wan.py::TestWanTransformer3DGGUFtest_gguf_quantization_inferencetest_gguf_keep_modules_in_fp32test_gguf_quantization_dtype_assignmenttest_gguf_quantization_lora_inferencetest_gguf_dequantizetest_gguf_quantized_layers
tests/models/transformers/test_models_transformer_wan.py::TestWanTransformer3DGGUFCompiletest_gguf_torch_compiletest_gguf_torch_compile_with_group_offload
Are these test failures expected?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Update Wan tests with new format
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.