[modular] add modular tests for Z-Image and Wan#13078
Open
[modular] add modular tests for Z-Image and Wan#13078
Conversation
sayakpaul
changed the title
yiyixuxu
reviewed
Feb 4, 2026
Collaborator
yiyixuxu
left a comment
yiyixuxu
left a comment
There was a problem hiding this comment.
thanks!
i left some comments
| assert self._get_batch_size_from_output(output_batch) == batch_size | ||
|
|
||
| # Convert outputs to tensors for comparison | ||
| if isinstance(output, list) and isinstance(output_batch, list): |
Collaborator
There was a problem hiding this comment.
are we trying to handle 3 different output formats here? (list of tensors, list of numpy arrays, single tensor)
Do we actually need all this? Shouldn't our pipeline outputs more or less standardized? at least when you pass a output_type
yiyixuxu
reviewed
Feb 5, 2026
| # Subclasses can override this to change the expected output type | ||
| output_name = "images" | ||
| # Whether the pipeline returns tensors directly with output_type="pt" or needs conversion | ||
| # Set to True for pipelines that don't support output_type parameter (e.g., WAN) |
Collaborator
There was a problem hiding this comment.
ohh it is for wan
actually can you add that argument for wan, probably just here https://github.com/huggingface/diffusers/blob/main/src/diffusers/modular_pipelines/wan/decoders.py#L52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
test_modular_pipelines_common.pyto account foroutput_type="video"and other changes that come with video pipelines.