Conversation
DN6
approved these changes
Dec 23, 2024
sayakpaul
commented
Dec 23, 2024
Comment on lines
-126
to
-131
| @skip_mps | ||
| @pytest.mark.xfail( | ||
| condition=torch.device(torch_device).type == "cpu" and is_torch_version(">=", "2.5"), | ||
| reason="Test currently fails on CPU and PyTorch 2.5.1 but not on PyTorch 2.4.1.", | ||
| strict=True, | ||
| ) |
Member
Author
There was a problem hiding this comment.
We don't need it here as it's implemented in tests/lora/utils.py.
sayakpaul
commented
Dec 23, 2024
Comment on lines
-147
to
-151
| @pytest.mark.xfail( | ||
| condition=torch.device(torch_device).type == "cpu" and is_torch_version(">=", "2.5"), | ||
| reason="Test currently fails on CPU and PyTorch 2.5.1 but not on PyTorch 2.4.1.", | ||
| strict=True, | ||
| ) |
sayakpaul
commented
Dec 23, 2024
Comment on lines
-106
to
-107
| @pytest.mark.xfail( | ||
| condition=torch.device(torch_device).type == "cpu" and is_torch_version(">=", "2.5"), |
sayakpaul
commented
Dec 23, 2024
| condition=torch.device(torch_device).type == "cpu" and is_torch_version(">=", "2.5"), | ||
| reason="Test currently fails on CPU and PyTorch 2.5.1 but not on PyTorch 2.4.1.", | ||
| strict=True, | ||
| strict=False, |
Member
Author
There was a problem hiding this comment.
This is because on CPU and PyTorch 2.5.1, SANA and HunyuanVideo pass this test. On GPU all pipelines pass this test.
DN6
approved these changes
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
device_map#9442 should be closed after this PR is merged.