Allow Mochi Transformer to be split across multiple GPUs#10300
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
a-r-r-o-w
approved these changes
Dec 19, 2024
Contributor
a-r-r-o-w
left a comment
There was a problem hiding this comment.
Oh... I think I definitely forgot _no_split_modules on some of the latest integrations. They would probably suffer with the same issues?
Collaborator
Author
|
@a-r-r-o-w Yeah it's a pretty safe addition to just add the transformer blocks to no split if you haven't already. |
Collaborator
Author
|
Failing example test is unrelated. |
Foundsheep
pushed a commit
to Foundsheep/diffusers
that referenced
this pull request
Dec 23, 2024
sayakpaul
pushed a commit
that referenced
this pull request
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Thanks to @jmahajan117 for flagging.
Ran this test on DGX and it passes
diffusers/tests/models/test_modeling_common.py
Line 1094 in 7667cfc
Example code:
Fixes # (issue)
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.