Skip to content

Add offload option in flux-control training#10225

Merged
sayakpaul merged 4 commits intohuggingface:mainfrom
Adenialzz:add-offload-option
Dec 15, 2024
Merged

Add offload option in flux-control training#10225
sayakpaul merged 4 commits intohuggingface:mainfrom
Adenialzz:add-offload-option

Conversation

@Adenialzz
Copy link
Contributor

Set model offloading to be optional in args, which will reduce the training memory usage but also reduce the training speed.

@sayakpaul

Copy link
Member

@sayakpaul sayakpaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

Adenialzz and others added 2 commits December 15, 2024 22:40
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sayakpaul
Copy link
Member

Could you run make style && make quality?

@Adenialzz
Copy link
Contributor Author

fixed now. ruff version issue

@sayakpaul sayakpaul merged commit 96a9097 into huggingface:main Dec 15, 2024
9 checks passed
@sayakpaul
Copy link
Member

Thanks for your PR!

@Adenialzz Adenialzz deleted the add-offload-option branch December 15, 2024 15:23
sayakpaul added a commit that referenced this pull request Dec 23, 2024
* Add offload option in flux-control training

* Update examples/flux-control/train_control_flux.py

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>

* modify help message

* fix format

---------

Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants