Remove mps workaround for fp16 GELU, which is now supported natively#10133
Merged
yiyixuxu merged 6 commits intohuggingface:mainfrom Dec 13, 2024
Merged
Remove mps workaround for fp16 GELU, which is now supported natively#10133yiyixuxu merged 6 commits intohuggingface:mainfrom
yiyixuxu merged 6 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
|
Thanks a lot @skotapati! Do you know the minimum PyTorch version that benefits from this? |
Contributor
|
@pcuenca Looks like it's been fixed since 1.13 pytorch/pytorch#86218 the code was originally added #1533 and at that time the minimum supported version for PyTorch was 1.4 |
Member
|
I tested on |
Contributor
Author
|
Makes sense, adding a check for torch>2.0 |
skotapati
force-pushed
the
skotapati/mps_gelu_workaround
branch
from
18ab1b9 to
d0feeae
Compare
Contributor
Author
|
@pcuenca thanks for the review, added the fallback for torch < 2.0 |
yiyixuxu
reviewed
Dec 6, 2024
pcuenca
approved these changes
Dec 12, 2024
Collaborator
|
thanks @skotapati @pcuenca @hlky ! |
sayakpaul
pushed a commit
that referenced
this pull request
Dec 23, 2024
…10133) * Remove mps workaround for fp16 GELU, which is now supported natively --------- Co-authored-by: hlky <hlky@hlky.ac>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes MPS fp16 GELU calls being forced to cast to fp32. fp16 GELU is now supported natively in MPS so this workaround is no longer needed
Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.