[LoRA] add a test to ensure set_adapters() and attn kwargs outs match#10110
Merged
[LoRA] add a test to ensure set_adapters() and attn kwargs outs match#10110
set_adapters() and attn kwargs outs match#10110Conversation
BenjaminBossan
approved these changes
Dec 4, 2024
Member
BenjaminBossan
left a comment
BenjaminBossan
left a comment
There was a problem hiding this comment.
Thanks, LGTM. Only a couple of nits from my side.
sayakpaul
commented
Dec 8, 2024
Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
DN6
approved these changes
Dec 12, 2024
sayakpaul
added a commit
that referenced
this pull request
Dec 23, 2024
…ch (#10110) * add a test to ensure set_adapters() and attn kwargs outs match * remove print * fix * Apply suggestions from code review Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com> * assertFalse. --------- Co-authored-by: Benjamin Bossan <BenjaminBossan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, users can set the scale of a loaded LoRA in a pipeline in two ways:
set_adapters(adapter_name, weight).attention_kwargs={"scale": weight}while calling the pipeline.This PR adds a test to ensure outputs from 1 and 2 match under identical settings.