Repository navigation
Handle UTF-8 BOMs in every JSON input file - #8841
Open
jinchuntan wants to merge 1 commit into
Open
jinchuntan wants to merge 1 commit into
jinchuntan wants to merge 1 commit into
Conversation
Strip the BOM at the start of each input file so JSON feature re-encoding works for later shards. Cover inferred and explicit features with regular and streaming multi-file loads. Assisted-by: Codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #8243. Strip the UTF-8 BOM at the start of each JSON input file. Multifile loads with inferred or explicit
List(Json())columns otherwise fail when a later file has a BOM.Adds eight regression cases covering inferred/explicit features and regular/streaming loads, including multiple batches and BOM characters inside values. Four cases fail on main. all eight pass with the fix.
Validation: JSON loader and reader tests: 63 passed, 11 skipped.
make qualitypasses.