fix(candle-kernels): disable BF16 WMMA kernels for pre-Ampere GPUs#3349
Open
DrJesseGlass wants to merge 5 commits intohuggingface:mainfrom
Open
fix(candle-kernels): disable BF16 WMMA kernels for pre-Ampere GPUs#3349DrJesseGlass wants to merge 5 commits intohuggingface:mainfrom
DrJesseGlass wants to merge 5 commits intohuggingface:mainfrom
Conversation
|
Thank you for the fix! I tried building with this, but it still fails in my GTX 1650 Ti. Here is the build log Details |
Contributor
Author
|
@OhashiReon I resolved the PTX flag issue and confirmed the build with compute_cap=75 (GTX 1650) |
|
Thank you for the update! I fixed it by adding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BF16 Tensor Core operations via WMMA require Ampere (sm_80) or newer. Pre-Ampere GPUs cannot compile BF16 WMMA fragment types, causing build failures on GTX 16xx and RTX 20xx cards.
So this adds a detect compute capability in build.rs via nvidia-smi and defines NO_BF16_WMMA for compute cap < 80.
Then places guard BF16 instantiations in moe_wmma.cu and moe_wmma_gguf.cu and emits an error message if BF16 is requested at runtime on unsupported hardware.
This way the FP16 WMMA and non-WMMA paths remain available.
Testing:
Builds and runs on DGX Spark (sm_100, BF16 WMMA enabled)
Hopefully GTX 16xx or RTX 20xx users in #3331 can verify.