Fix flaky GELU test and clippy warnings in candle-onnx#3317
Open
Douglas-Nyberg wants to merge 3 commits intohuggingface:mainfrom
Open
Fix flaky GELU test and clippy warnings in candle-onnx#3317Douglas-Nyberg wants to merge 3 commits intohuggingface:mainfrom
Douglas-Nyberg wants to merge 3 commits intohuggingface:mainfrom
Conversation
Member
|
Thanks! I'm happy to merge parts of this PR, but candle-onnx is actually purposefully excluded from workspace / CI. |
Author
|
Thanks for the feedback! I've reverted the changes to Cargo.toml and the CI workflow as requested. Fix for the flaky GELU test: Switched to approximate comparison to handle floating point differences. Let me know if you would like to see something else. |
Douglas-Nyberg
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
test_gelu_operationincandle-onnxto use approximate float comparison (was failing due to precision differences).candle-onnx/src/eval.rs.Why
While running tests locally, I found that
test_gelu_operationwas flaky due to using exact float equality. Additionally,cargo clippyrevealed several issues ineval.rsthat needed fixing.(Note: I originally attempted to add
candle-onnxto the workspace/CI, but reverted that infrastructure change per maintainer feedback to focus solely on these code fixes.)Testing
All 64
candle-onnxtests pass locally.cargo clippypasses.