Two exceptions caused hang/infinite loop in QueryBuilderCommon.java #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
executeRequest needs to close the request before throwing an exception. Otherwise there will be no open connections to use after two exceptions are thrown. This comment helped me figure it out. https://stackoverflow.com/questions/33650157/httpclient-stop-executing-the-same-httpget-method-in-a-loop-after-executing-twic/33650384#33650384
tylerbath
changed the title
|
It appears that we both found the same issue at a similar time. I reported the issue here #28 and created a pull request as well, which the author accepted. I resolved it slightly differently than you did, but functionally we do the same thing (#29). I'm sorry for duplicating your effort - that was not intentional, but I don't think this Pull Request is necessary anymore |
Author
|
Thanks for the update, I will close this request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
executeRequest needs to close the request before throwing an exception. Otherwise there will be no open connections to use after two exceptions are thrown. I discovered this running the BlockCommandTest.java without changing the hash used for specific block retrieval.
This comment helped me figure it out. https://stackoverflow.com/questions/33650157/httpclient-stop-executing-the-same-httpget-method-in-a-loop-after-executing-twic/33650384#33650384