Update to newer version of jjwt library#1727
Merged
bitwiseman merged 11 commits intohub4j:mainfrom Nov 9, 2023
Merged
Conversation
Member
|
NOTE: I expect this will fail code coverage due the reflective code not being covered. I can manually override that. |
When I went to run tests on the reflection code I ran into a number of errors. A few were straighfoward fixes but not all. The issue requiring the biggest change as that some JWT suite classes were being loaded as the JwtBuilderUtil class was being loaded, or at least before the buildJwt() method started executing. I had to move the JWT calls into a nested class to delay the loading of JWT suite classes until inside a try-catch where I could handle it as expected.
Member
|
@ihrigb |
bitwiseman
reviewed
Nov 8, 2023
src/main/java/org/kohsuke/github/extras/authorization/JwtBuilderUtil.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention:
📢 Thoughts on this report? Let us know! |
Contributor
Author
|
@bitwiseman I don't mind at all. Thanks for the testing effort. I marked the PR ready. |
This makes it so we only need to check once for which implementation to use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1724
Description
jjwt recently introduced an incompatible change in their API. This addresses and fixes it. (see #1724)
This may leed to problems as jjwt is an optional dependency. Users would also need to update the jjwt version once they will update to a new build of the github-api.
Before submitting a PR:
@linkJavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.main. You will create your PR from that branch.When creating a PR: