feat: Support merge_group events#1726
Merged
bitwiseman merged 1 commit intohub4j:mainfrom Oct 13, 2023
felipefrancisco:support-merge-group-event
Merged
feat: Support merge_group events#1726bitwiseman merged 1 commit intohub4j:mainfrom felipefrancisco:support-merge-group-event
merge_group events#1726bitwiseman merged 1 commit intohub4j:mainfrom
felipefrancisco:support-merge-group-event
Conversation
Contributor
Author
|
Hey @bitwiseman, apologies for the direct ping - I noticed that you're an active contributor to this project, so I was hoping you could kindly have a look through this very short PR in case you get a chance. |
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
bitwiseman
approved these changes
Oct 13, 2023
Contributor
Author
|
Thank you for the speedy feedback @bitwiseman 🙏🏽 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Important
DISCLAIMER: I'm not a Java developer - This PR is based on the changes implemented in #1316, which seemed quite simple to do, so I'm proposing these changes for review.
This PR adds support for merge_group events fired by merge queues, please see the official documentation for details:
merge_groupevent definition in workflow docsI'm submitting this PR since I'm using
jenkinsci/github-plugin, which is failing to accept these valid events fired by Github. It does an event-check here based onorg.kohsuke.github.GHEvent(defined by this project) and, sincemerge_groupis not a supported event, it fails with "Hook should contain event type".Here's an example of what I see on Github Settings > Webhook on my end when Jenkins receives that payload:
Before submitting a PR:
@linkJavaDoc entries to the relevant documentation on https://docs.github.com/en/rest .mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.main. You will create your PR from that branch.When creating a PR: