Add support for repositories body parameter when creating installation access tokens#1492
Merged
bitwiseman merged 3 commits intohub4j:mainfrom Aug 13, 2022
Conversation
dwnusbaum
commented
Jul 27, 2022
| * Array containing the repository names | ||
| * @return a GHAppCreateTokenBuilder | ||
| */ | ||
| @BetaApi |
Contributor
Author
There was a problem hiding this comment.
From a bit of reading I think this API is out of beta now, but I added this annotation anyways to match the other methods in this class. Let me know if I should remove the annotation or anything.
| @Test | ||
| public void createTokenWithRepositories() throws IOException { | ||
| GHApp app = gitHub.getApp(); | ||
| GHAppInstallation installation = app.getInstallationByUser("bogus"); |
Contributor
Author
There was a problem hiding this comment.
IDK if this is the preferred approach, but it matches the above createToken test (I ran it against a real app and everything though when generating the stubs and then just changed the names to match the other test).
Codecov Report
@@ Coverage Diff @@
## main #1492 +/- ##
=========================================
Coverage 78.80% 78.81%
- Complexity 2113 2114 +1
=========================================
Files 202 202
Lines 6427 6429 +2
Branches 361 361
=========================================
+ Hits 5065 5067 +2
Misses 1152 1152
Partials 210 210
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bitwiseman
approved these changes
Aug 10, 2022
bitwiseman
approved these changes
Aug 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for the
repositoriesbody parameter as specified in https://docs.github.com/en/rest/apps/apps#create-an-installation-access-token-for-an-app toGHAppCreateTokenBuilder.Originally, if you wanted to generate an installation access token limited to a specific repository, the
/app/installations/{installation_id}/access_tokensendpoint required you to pass arepository_idsbody parameter. That parameter is a bit awkward because generally you will need to make an additional API call to retrieve the ID of a repository given its name.At some point (I could not find a changelog) GitHub added a
repositoriesbody parameter that works likerepository_ids, but accepts repository names rather than IDs, which is a nice improvement.Before submitting a PR:
mvn -D enable-ci clean install sitelocally. If this command doesn't succeed, your change will not pass CI.main. You will create your PR from that branch.When creating a PR: