Skip to content

Fix SpotBugs warning regarding putIfAbsent()#1424

Merged
bitwiseman merged 1 commit intomainfrom
bitwiseman-patch-1
Apr 9, 2022
Merged

Fix SpotBugs warning regarding putIfAbsent()#1424
bitwiseman merged 1 commit intomainfrom
bitwiseman-patch-1

Conversation

@bitwiseman
Copy link
Member

Description

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments as appropriate. Consider including links in comments to relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #1424 (c3e0ba1) into main (68aeab2) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1424      +/-   ##
============================================
- Coverage     78.40%   78.40%   -0.01%     
  Complexity     2079     2079              
============================================
  Files           201      201              
  Lines          6354     6352       -2     
  Branches        357      357              
============================================
- Hits           4982     4980       -2     
  Misses         1164     1164              
  Partials        208      208              
Impacted Files Coverage Δ
src/main/java/org/kohsuke/github/GitHub.java 82.19% <100.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68aeab2...c3e0ba1. Read the comment docs.

@bitwiseman bitwiseman merged commit c3252c4 into main Apr 9, 2022
@bitwiseman bitwiseman deleted the bitwiseman-patch-1 branch April 9, 2022 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant