- added 'RolePermission' to allow specifying custom roles#1403
- added 'RolePermission' to allow specifying custom roles#1403bitwiseman merged 3 commits intohub4j:mainfrom jgangemi:jae/role-perm
Conversation
|
Build output says it: |
|
Could send a link to the documentation for the endpoint and maybe any blog post announcing the change? It would help me understand the new behavior vs the old. |
|
basically instead of just having the pre-defined roles like before, you can create your own custom role that has additional permissions. for example, i created a i'm trying to find the documentation for the endpoint, but i know it's listed there. |
|
this allows for the "custom" role to be defined and also provides the "pre-canned". |
|
@bitwiseman ping :) - i'd like to get this nailed down as it's something i need. |
bitwiseman
left a comment
There was a problem hiding this comment.
Basically yes, just some feedback.
Codecov Report
@@ Coverage Diff @@
## main #1403 +/- ##
============================================
+ Coverage 78.22% 78.40% +0.18%
- Complexity 2073 2079 +6
============================================
Files 201 201
Lines 6341 6354 +13
Branches 357 357
============================================
+ Hits 4960 4982 +22
+ Misses 1172 1164 -8
+ Partials 209 208 -1
Continue to review full report at Codecov.
|
|
@bitwiseman do you want me to work those coverage numbers up or is this good to go? |
|
@bitwiseman ping :) |
bitwiseman
left a comment
There was a problem hiding this comment.
@jgangemi
I can see that the previous functionality wasn't covered well, but yes, we need to bring the coverage numbers up before merging. Add some more tests covering the deprecated methods as well. Thanks!
|
@bitwiseman good news/bad news! i got the coverage numbers up but now the build is failing and complaining about some missing constructor. i didn't make any changes here, so i'm confused as to what is going on. |
|
@jgangemi |
|
welp, looks like it's green now. can i get a merge and release? :) |
|
@bitwiseman what happened to the release? can i get another cut? https://github.com/hub4j/github-api/releases/tag/github-api-1.304 |
Oh, right, sorry. I clicked the wrong button and GitHub marked a release as published. I wasn't ready to do one though so I rolled it back. I'll release 1.304 when I'm back from vacation this Friday. |
|
thanks! enjoy!!! |
better fix for #1377, tests after this is ok-ed.
@bitwiseman didn't there used to be some way to format the code through maven?