Skip to content

Added user LDAP information.#1401

Merged
bitwiseman merged 10 commits intohub4j:mainfrom
kartikpatodi:main
Apr 9, 2022
Merged

Added user LDAP information.#1401
bitwiseman merged 10 commits intohub4j:mainfrom
kartikpatodi:main

Conversation

@kartikpatodi
Copy link
Contributor

@kartikpatodi kartikpatodi commented Mar 12, 2022 •
edited
Loading

Description

Changes for #1400

Before submitting a PR:

  • Changes must not break binary backwards compatibility. If you are unclear on how to make the change you think is needed while maintaining backward compatibility, CONTRIBUTING.md for details.
  • Add JavaDocs and other comments as appropriate. Consider including links in comments to relevant documentation on https://docs.github.com/en/rest .
  • Add tests that cover any added or changed code. This generally requires capturing snapshot test data. See CONTRIBUTING.md for details.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.
  • Push your changes to a branch other than main. You will create your PR from that branch.

When creating a PR:

  • Fill in the "Description" above with clear summary of the changes. This includes:
    • If this PR fixes one or more issues, include "Fixes #" lines for each issue.
    • Provide links to relevant documentation on https://docs.github.com/en/rest where possible.
  • All lines of new code should be covered by tests as reported by code coverage. Any lines that are not covered must have PR comments explaining why they cannot be covered. For example, "Reaching this particular exception is hard and is not a particular common scenario."
  • Enable "Allow edits from maintainers".

@kartikpatodi
Copy link
Contributor Author

kartikpatodi commented Mar 12, 2022

For #1400

gsmet
gsmet reviewed Mar 14, 2022
View reviewed changes
@bitwiseman
Copy link
Member

bitwiseman commented Mar 15, 2022

@kartikpatodi
We're going to need links to docs to evaluate the accuracy of this. Also, at least one test.

@kartikpatodi
Copy link
Contributor Author

kartikpatodi commented Mar 17, 2022

@bitwiseman

https://docs.github.com/en/enterprise-server@3.3/admin/identity-and-access-management/authenticating-users-for-your-github-enterprise-server-instance/using-ldap

@bitwiseman
Copy link
Member

bitwiseman commented Mar 28, 2022

@kartikpatodi
Please include the link in the JavaDoc for the method. And we're going to need test coverage.

@bitwiseman bitwiseman marked this pull request as draft March 28, 2022 17:16
@bitwiseman
Copy link
Member

bitwiseman commented Mar 28, 2022

Converted to draft until tests are added.

@kartikpatodi kartikpatodi marked this pull request as ready for review April 4, 2022 19:51
@kartikpatodi
Copy link
Contributor Author

kartikpatodi commented Apr 4, 2022

@bitwiseman Added a test

bitwiseman
bitwiseman reviewed Apr 9, 2022
View reviewed changes
@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #1401 (5396ed7) into main (c3252c4) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##               main    #1401   +/-   ##
=========================================
  Coverage     78.40%   78.40%           
- Complexity     2079     2080    +1     
=========================================
  Files           201      201           
  Lines          6352     6354    +2     
  Branches        357      357           
=========================================
+ Hits           4980     4982    +2     
  Misses         1164     1164           
  Partials        208      208
Impacted Files Coverage Δ
src/main/java/org/kohsuke/github/GHUser.java 60.41% <100.00%> (+1.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3252c4...5396ed7. Read the comment docs.

@bitwiseman bitwiseman merged commit d226125 into hub4j:main Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitwiseman bitwiseman bitwiseman approved these changes

+1 more reviewer

@gsmet gsmet gsmet left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kartikpatodi @bitwiseman @gsmet