Skip to content

Migrate to use Github Actions instead of CircleCI #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Vkt0r merged 10 commits into from
May 18, 2020
Merged

Migrate to use Github Actions instead of CircleCI #448

Vkt0r merged 10 commits into from
May 18, 2020

Conversation

@Vkt0r
Copy link
Member

@Vkt0r Vkt0r commented Apr 11, 2020 •
edited
Loading

The purpose of this PR is to migrate the workflows in CircleCI to Github Actions.

  • CircleCI was presenting a lot of problems with the Linux containers and the OSS plans causing inconsistencies in the tests. Github Actions is completely free for OSS and fits our needs for this project.
  • Reorder the ServerThreadingTests in the XCTManifest as it was causing flakiness in Linux.

@Vkt0r Vkt0r force-pushed the gitHub-actions branch 3 times, most recently from c1e3e59 to 8c89d4b Compare April 11, 2020 05:10
@httpswift httpswift deleted a comment from swifter-bot Apr 11, 2020
@swifter-bot
Copy link

swifter-bot commented Apr 11, 2020 •
edited
Loading

1 Message
📖 Hey, @Vkt0r 👋.

Generated by 🚫 Danger

@Vkt0r Vkt0r force-pushed the gitHub-actions branch 6 times, most recently from cca4d5d to 00ed1d6 Compare April 11, 2020 06:09
@Vkt0r Vkt0r mentioned this pull request Apr 18, 2020
Merged
@Vkt0r Vkt0r force-pushed the gitHub-actions branch from 065f09d to 172d53e Compare May 16, 2020 19:09
@Vkt0r Vkt0r force-pushed the gitHub-actions branch from 172d53e to 74547b7 Compare May 16, 2020 19:15
@Vkt0r Vkt0r force-pushed the gitHub-actions branch from 7e753b9 to 7dc007b Compare May 16, 2020 19:23
@Vkt0r Vkt0r marked this pull request as ready for review May 16, 2020 19:27
@Vkt0r Vkt0r requested review from adamkaplan and julien-c May 16, 2020 19:27
@Vkt0r Vkt0r requested a review from pvzig May 16, 2020 19:27
pvzig
pvzig approved these changes May 17, 2020
View reviewed changes
Copy link
Collaborator

@pvzig pvzig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@Vkt0r Vkt0r merged commit e9b1d5e into stable May 18, 2020
@Vkt0r Vkt0r deleted the gitHub-actions branch May 18, 2020 03:57
tomieq pushed a commit to tomieq/swifterfork that referenced this pull request Apr 1, 2021
@Vkt0r
Merge pull request httpswift#448 from httpswift/gitHub-actions
50a4120 
Migrate to use Github Actions instead of CircleCI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pvzig pvzig pvzig approved these changes

@adamkaplan adamkaplan Awaiting requested review from adamkaplan

@julien-c julien-c Awaiting requested review from julien-c

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Vkt0r @swifter-bot @pvzig