Skip to content

Import FoundationNetworking on Linux to fix tests. #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Vkt0r merged 2 commits into from
Apr 18, 2020
Merged

Import FoundationNetworking on Linux to fix tests. #446

Vkt0r merged 2 commits into from
Apr 18, 2020

Conversation

@kbongort
Copy link

@kbongort kbongort commented Apr 10, 2020

FoundationNetworking is required for NSURLSession and such.

@swifter-bot
Copy link

swifter-bot commented Apr 10, 2020 •
edited
Loading

2 Warnings
⚠️ It seems like you’ve added new tests to the library. If that’s the case, please update the XCTestManifests.swift file running in your terminal the command swift test --generate-linuxmain.
⚠️ If you ran the command swift test --generate-linuxmain in your terminal, please remove the line testCase(IOSafetyTests.__allTests__IOSafetyTests), from public func __allTests() -> [XCTestCaseEntry] in the bottom of the file. For more reference see #366.
1 Message
📖 Hey, @kbongort 👋.

Generated by 🚫 Danger

@Vkt0r
Copy link
Member

Vkt0r commented Apr 18, 2020

Hey, @kbongort Thanks for taking the time to fix this! I already integrated your changes in a draft PR #448 I've to fix the Linux infrastructure issue with CircleCI. Please rebase and update this PR in order to merge it.

@kbongort
Copy link
Author

kbongort commented Apr 18, 2020

@Vkt0r do you need me to update this PR or should I just close it since you've incorporated the same changes into #448?

@Vkt0r
Copy link
Member

Vkt0r commented Apr 18, 2020

@kbongort Please update it to merge it. I integrated your changes to test my branch, I'll rebase it once yours is in the stable branch.

@kbongort
Copy link
Author

kbongort commented Apr 18, 2020

@Vkt0r Ok, I've updated this PR.

@Vkt0r Vkt0r merged commit abc4a02 into httpswift:stable Apr 18, 2020
tomieq pushed a commit to tomieq/swifterfork that referenced this pull request Apr 1, 2021
@Vkt0r
Merge pull request httpswift#446 from kbongort/FixLinuxTests
9b85a36 
Import FoundationNetworking on Linux to fix tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kbongort @swifter-bot @Vkt0r @ken-broadsheet