Use Foundation API for Base64 Encoding #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Sources/HttpParser.swift # XCode/Sources/String+BASE64.swift
Generated by 🚫 Danger |
Member
|
@Mazyod Danger would require it 😅 |
Member
|
This is weird I have to rebuild the Linux job the PR three times in CircleCI regarding issues with the Docker image and your PR was working from me in Linux with the same Docker image locally for me since the beginning 🤔. Anyways I would file a report with them for investigation. |
Vkt0r
approved these changes
May 1, 2019
Member
Vkt0r
left a comment
Vkt0r
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks again for your contribution.
tomieq
pushed a commit
to tomieq/swifterfork
that referenced
this pull request
Apr 1, 2021
…ase64-encoding Use Foundation API for Base64 Encoding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note, I didn't see the need to update the changelog, as this is extremely minor and should be transparent to the users. If you'd like an entry anyway, I can add that as well.
Fixes #394.